formulary: fix error with absolute alias paths #13888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
added
the
critical
|
Review period skipped due to |
BrewTestBot
approved these changes
Sep 19, 2022
|
Nice catch; thanks! I was looking at e8f2d8f, but couldn't work out what could be causing the problem. |
|
Nice catch @Bo98! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13883.
This broke in e8f2d8f in a non-obvious way.
CoreTap.instance.alias_dir/refwhererefis an absolute path will just returnrefitself, but after that commit meant it was lowercased which breaks on case-sensitive systems.I've tweaked the code to explicitly check if we are using an absolute path
refto make the code not rely on weird side effects like that.