Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks GitHub API if homepage 404s during brew audit --online #13907

Conversation

troymccabe
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes #13789

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Nice work.

Library/Homebrew/utils/curl.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/curl.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/curl.rb Outdated Show resolved Hide resolved
@troymccabe
Copy link
Contributor Author

🙏 Thanks again for the review! Please lmk if there's anything else that needs to change

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again @troymccabe!

@troymccabe troymccabe changed the title Checks github API if homepage 404s Checks GitHub API if homepage 404s during brew audit --online Sep 21, 2022
@troymccabe
Copy link
Contributor Author

Of course! I'm poking through the other help_wanted issues to see if there's others I can pick up. Has been fun!

Anything I should change on my end for the codecov/project check? Looks like a bunch of unrelated coverage % change in codecov: https://github.com/Homebrew/brew/pull/13907/checks?check_run_id=8472344053

@MikeMcQuaid MikeMcQuaid merged commit fbbcb97 into Homebrew:master Sep 21, 2022
@MikeMcQuaid
Copy link
Member

Of course! I'm poking through the other help_wanted issues to see if there's others I can pick up. Has been fun!

Glad to hear it, thanks for contributing!

Anything I should change on my end for the codecov/project check? Looks like a bunch of unrelated coverage % change in codecov: https://github.com/Homebrew/brew/pull/13907/checks?check_run_id=8472344053

No big deal here, mainly for catching actual user logic changes.

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew audit --online not adding the HOMEBREW_GITHUB_API_TOKEN as HTTP Authorization Header
2 participants