Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_auditor: fix false negatives in audit_gcc_dependency #13918

Merged
merged 1 commit into from Sep 22, 2022

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This audit is mistakenly passing for formulae where
variations_dependencies is an empty array. We can fix that by checking
for nil instead.

See Homebrew/homebrew-core#111280.

This audit is mistakenly passing for formulae where
`variations_dependencies` is an empty array. We can fix that by checking
for `nil` instead.

See Homebrew/homebrew-core#111280.
@carlocab carlocab added the critical Critical change which should be shipped as soon as possible. label Sep 22, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@carlocab carlocab merged commit 4441452 into Homebrew:master Sep 22, 2022
@carlocab carlocab deleted the fix_gcc_dependency branch September 22, 2022 22:25
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants