Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function from bump-cask-pr #13939

Merged

Conversation

apainintheneck
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The function fetch_cask was originally added in f65f0f9 and the final reference to it was removed in 092095a.

@apainintheneck apainintheneck self-assigned this Sep 28, 2022
@BrewTestBot
Copy link
Member

Review period will end on 2022-09-29 at 04:27:55 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 28, 2022
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Sep 28, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 28, 2022
@apainintheneck apainintheneck merged commit 7b00b2b into Homebrew:master Sep 29, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
@apainintheneck apainintheneck deleted the rm-unused-fetch-cask-function branch January 3, 2023 00:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants