Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple macOS requirements #14122

Merged
merged 1 commit into from Nov 9, 2022
Merged

Allow multiple macOS requirements #14122

merged 1 commit into from Nov 9, 2022

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Nov 9, 2022 •
edited

We store requirements in a set which means we strip out any duplicate requirements.

However, this was too strict for macOS requirements, as the uniqueness checks did not consider different comparators and versions.

This meant that:

depends_on macos: :mojave
depends_on maximum_macos: :big_sur

would incorrectly be combined to only one of them - usually the first.

Now with the changes in this PR, macOS requirements will only be combined if they are truly identical (e.g. if depends_on macos: :mojave appeared twice).

@BrewTestBot
Copy link
Member

Review period will end on 2022-11-10 at 01:24:52 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 9, 2022
@Bo98 Bo98 mentioned this pull request Nov 9, 2022
Closed
6 tasks
MikeMcQuaid
MikeMcQuaid approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @Bo98!

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Nov 9, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 9, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Bo98 Bo98 merged commit d385212 into Homebrew:master Nov 9, 2022
@Bo98 Bo98 deleted the multiple-macos branch November 9, 2022 12:13
@timsutton
Copy link
Sponsor Member

Thanks for landing this!

@github-actions github-actions bot added the outdated PR was locked due to age label Dec 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Bo98 @BrewTestBot @timsutton @MikeMcQuaid