Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: Switch from HackerOne to GitHub for vulnerability reporting #14132

Merged
merged 2 commits into from Nov 18, 2022
Merged

README: Switch from HackerOne to GitHub for vulnerability reporting #14132

merged 2 commits into from Nov 18, 2022

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Nov 10, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • This was launched yesterday, we were early adopters. I (independently, zero pressure from my employer) think there's benefit in a centralized vulnerability reporting mechanism that's closer to the code and easier for researchers to find.

@issyl0
README: Switch from HackerOne to GitHub for vulnerability reporting
6691a7f 
- This was launched yesterday, we were early adopters. I (independently,
  zero pressure from my employer) think there's benefit in a centralized
  vulnerability reporting mechanism that's closer to the code and easier
  for researchers to find.
@BrewTestBot
Copy link
Member

Review period will end on 2022-11-11 at 11:07:55 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 10, 2022
MikeMcQuaid
MikeMcQuaid reviewed Nov 10, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@issyl0 issyl0 mentioned this pull request Nov 10, 2022
Merged
@issyl0 @MikeMcQuaid
README: Better words for what the security form is
6d3340a 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 11, 2022
@BrewTestBot
Copy link
Member

Review period ended.

@MikeMcQuaid MikeMcQuaid requested a review from a team November 18, 2022 15:47
MikeMcQuaid
MikeMcQuaid approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TSC took a vote on migration from HackerOne and we had four in favour and one opposed to the migration so: we will be migrating.

@MikeMcQuaid MikeMcQuaid merged commit 83d62ce into Homebrew:master Nov 18, 2022
@issyl0 issyl0 deleted the switch-from-hackerone-to-github-vulnerability-reporting branch November 19, 2022 15:53
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 20, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@issyl0 @BrewTestBot @MikeMcQuaid