Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install <cask> --dry-run #14138

Merged
merged 1 commit into from Nov 14, 2022

Conversation

danielbayley
Copy link
Contributor

@danielbayley danielbayley commented Nov 11, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes the following error, when running brew install --dry-run:

> brew install <cask> --dry-run
==> Would install 1 cask:
<cask>
Error: uninitialized constant Cask::Cmd::Install::CaskDependent
/usr/local/Homebrew/Library/Homebrew/cask/cmd/install.rb:94:in `block in install_casks'
/usr/local/Homebrew/Library/Homebrew/cask/cmd/install.rb:93:in `each'
/usr/local/Homebrew/Library/Homebrew/cask/cmd/install.rb:93:in `install_casks'
/usr/local/Homebrew/Library/Homebrew/cmd/install.rb:192:in `install'
/usr/local/Homebrew/Library/Homebrew/brew.rb:95:in `<main>'

@apainintheneck apainintheneck added the cask Homebrew Cask label Nov 11, 2022
Copy link
Contributor

@apainintheneck apainintheneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikeMcQuaid MikeMcQuaid merged commit b739106 into Homebrew:master Nov 14, 2022
@MikeMcQuaid
Copy link
Member

Good catch thanks again @danielbayley!

@danielbayley danielbayley deleted the cmd-install-dry-run branch November 14, 2022 12:21
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cask Homebrew Cask outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants