Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update Contributors section #14152

Merged
merged 2 commits into from Nov 17, 2022
Merged

docs: update Contributors section #14152

merged 2 commits into from Nov 17, 2022

Conversation

EricFromCanada
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

In this week's episode of reworking the docs: the rest of the Contributors section. (Previously: #12431, #12505, #14023, #14140)

@EricFromCanada
Contributors docs: adjust line breaks
034bf72
@EricFromCanada
Contributors docs: content & formatting updates
d615899 
Update How-To-Open-a-Homebrew-Pull-Request.md

Update Acceptable-Formulae.md

Update Acceptable-Casks.md

Update License-Guidelines.md

Update Versions.md

Update Versions.md

Update Deprecating-Disabling-and-Removing-Formulae.md

Update Node-for-Formula-Authors.md

Update Python-for-Formula-Authors.md

Update Brew-Livecheck.md

Update Migrating-A-Formula-To-A-Tap.md

Update Rename-A-Formula.md

Update How-to-Create-and-Maintain-a-Tap.md

Update Brew-Test-Bot.md

Update Typechecking.md
@BrewTestBot
Copy link
Member

Review period will end on 2022-11-17 at 14:25:27 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 16, 2022
@MikeMcQuaid
Copy link
Member

Thanks again @EricFromCanada!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 17, 2022
@BrewTestBot
Copy link
Member

Review period ended.

@MikeMcQuaid MikeMcQuaid merged commit 129c5c2 into Homebrew:master Nov 17, 2022
@EricFromCanada EricFromCanada deleted the docs-contributors-fixes branch November 17, 2022 16:16
@EricFromCanada EricFromCanada mentioned this pull request Dec 4, 2022
Merged
7 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EricFromCanada @BrewTestBot @MikeMcQuaid