Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocop_todo: Clean up deleted paths & excludes without offenses #14162

Merged
merged 2 commits into from Nov 21, 2022

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Nov 20, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

  • What it says on the tin.

@BrewTestBot
Copy link
Member

Review period will end on 2022-11-22 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 20, 2022
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Nov 21, 2022
@MikeMcQuaid
Copy link
Member

Thanks for this!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 21, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@issyl0 issyl0 merged commit 38a1bf3 into Homebrew:master Nov 21, 2022
@issyl0 issyl0 deleted the rubocop-cleanup branch November 21, 2022 14:48
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants