Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent brew casks from finding formulae at tap root #14164

Merged

Conversation

ThatsJustCheesy
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Currently, brew casks will print names of formulae defined at the root of a tap repository. e.g. for this tap:

$ brew tap cartr/qt4
# …
Tapped 23 formulae (43 files, 222.1KB).

$ brew casks | grep 'cartr/qt4'
cartr/qt4/automoc4
cartr/qt4/coin@3.1.3
cartr/qt4/cuty_capt
cartr/qt4/ezlupdate
# …

I'm assuming this is a bug, so here is my best attempt at a fix.

All tests pass, but I'm not sure any exist for brew formulae and brew casks. From my manual testing, they appear to now work as I would expect.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks again @ThatsJustCheesy!

@MikeMcQuaid MikeMcQuaid merged commit 9637c0f into Homebrew:master Nov 21, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants