New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
formula_creator: use tool-agnostic meson commands #14193
Conversation
Review period will end on 2022-12-01 at 20:31:44 UTC. |
Review period ended. |
system "ninja", "install", "-v" | ||
end | ||
system "meson", "setup", "build", *std_meson_args | ||
system "meson", "compile", "-C", "build", "--verbose" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this will simply import approximately 190 python files amounting to 70k lines of code, check whether the setup was configured with an explicit --backend option and thus doesn't use the default ninja, and potentially run either one of:
ninja -v
xcodebuild
It adds no capabilities over ninja, but if you prefer it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly matching current style preference in homebrew-core
. Similar to CMake changes, though there is probably more overhead in Meson's Python code path than CMake's C/C++. I assume it isn't going to make a noticeable impact when actually run on CI. It leaves open the possibility of tweaking our std_meson_args
backend (even if it is an unlikely change).
At least other repositories that also directly run commands in packages (e.g. Arch, Alpine) seem to favor running through Meson.
Repositories that use their own helper commands (e.g. Debian, Fedora) seem to directly run Ninja behind the scenes (e.g. Fedora's %meson_build
being an alias for %ninja_build
)
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Similar to CMake changes. This uses Meson's standard workflow which we have started to use in core formulae.