Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_creator: use tool-agnostic meson commands #14193

Merged
merged 1 commit into from Feb 12, 2023

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 30, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Similar to CMake changes. This uses Meson's standard workflow which we have started to use in core formulae.

@BrewTestBot
Copy link
Member

Review period will end on 2022-12-01 at 20:31:44 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 30, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 1, 2022
@BrewTestBot
Copy link
Member

Review period ended.

system "ninja", "install", "-v"
end
system "meson", "setup", "build", *std_meson_args
system "meson", "compile", "-C", "build", "--verbose"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this will simply import approximately 190 python files amounting to 70k lines of code, check whether the setup was configured with an explicit --backend option and thus doesn't use the default ninja, and potentially run either one of:

  • ninja -v
  • xcodebuild

It adds no capabilities over ninja, but if you prefer it...

Copy link
Member Author

@cho-m cho-m Dec 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly matching current style preference in homebrew-core. Similar to CMake changes, though there is probably more overhead in Meson's Python code path than CMake's C/C++. I assume it isn't going to make a noticeable impact when actually run on CI. It leaves open the possibility of tweaking our std_meson_args backend (even if it is an unlikely change).

At least other repositories that also directly run commands in packages (e.g. Arch, Alpine) seem to favor running through Meson.

Repositories that use their own helper commands (e.g. Debian, Fedora) seem to directly run Ninja behind the scenes (e.g. Fedora's %meson_build being an alias for %ninja_build)

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Dec 30, 2022
@cho-m cho-m removed the stale No recent activity label Dec 30, 2022
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Jan 21, 2023
@cho-m cho-m removed the stale No recent activity label Jan 21, 2023
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Feb 12, 2023
@carlocab carlocab merged commit ccbb173 into Homebrew:master Feb 12, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2023
@cho-m cho-m deleted the meson-creator branch March 5, 2024 02:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants