ElectronBuilder: Allow Date/Time deserialization #14205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2022-12-06 at 02:43:06 UTC. |
BrewTestBot
added
the
waiting for feedback
p-linnane
approved these changes
Dec 5, 2022
SMillerDev
approved these changes
Dec 5, 2022
MikeMcQuaid
approved these changes
Dec 5, 2022
The `ElectronBuilder` strategy uses `YAML#safe_load` to parse YAML content and this limits deserialization to appropriate classes. We recently encountered a `Tried to load unspecified class: Time` error when using the `ElectronBuilder` strategy on a `latest-mac.yml` file containing `releaseDate: 2022-12-01T02:02:46.419Z`. The electron-builder YAML files we usually encounter use single quotes around the `releaseDate` value to ensure it's treated as a string (e.g., `releaseDate: '2022-10-12T17:55:26.718Z'`) and this is what we do in `electron_builder_spec.rb`. The aforementioned YAML file doesn't use single quotes around the value, so it's treated as a timestamp and apparently this makes Psych use `Time` (which `#safe_load` doesn't allow by default). Seeing as we can't control the YAML content and there's a chance we may encounter other files like this in the future, this commit modifies the related `#safe_load` call to allow `Time` (and `Date` for good measure). This will resolve the aforementioned error and allow the `ElectronBuilder` strategy to work as expected in this scenario.
samford
force-pushed
the
livecheck/electronbuilder-allow-date-time-deserialization
branch
from
2b8100d
to
e56735a
Compare
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Dec 6, 2022
samford
deleted the
livecheck/electronbuilder-allow-date-time-deserialization
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?The
ElectronBuilderstrategy usesYAML#safe_loadto parse YAML content and this limits deserialization to appropriate classes. We recently encountered aTried to load unspecified class: Timeerror when using theElectronBuilderstrategy on alatest-mac.ymlfile containingreleaseDate: 2022-12-01T02:02:46.419Z.The electron-builder YAML files we usually encounter use single quotes around the
releaseDatevalue to ensure it's treated as a string (e.g.,releaseDate: '2022-10-12T17:55:26.718Z') and this is what we do inelectron_builder_spec.rb. The aforementioned YAML file doesn't use single quotes around the value, so it's treated as a timestamp and apparently this makes Psych useTime(which#safe_loaddoesn't allow by default).There's something to be said for upstream simply using single quotes around this value (the electron-builder documentation seems to suggest the value should be a string) but that's not something we can directly control and we may encounter other files like this in the future. With that in mind, this PR modifies the related
#safe_loadcall to allowTime(andDatefor good measure), which will resolve the aforementioned error and allow theElectronBuilderstrategy to work as expected in this scenario.