Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/bump: check if Repology output is a version first #14210

Merged
merged 1 commit into from Dec 6, 2022

Conversation

dawidd6
Copy link
Member

@dawidd6 dawidd6 commented Dec 5, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Follow-up to: #14190

Before:

Mon 05 Dec 16:16:05 ➜  Library/Homebrew stash master ✓  brew bump cortex --open-pr
==> cortex
Current formula version:  1.13.1
Latest livecheck version: 1.14.0
Latest Repology version:  present only in Homebrew
Open pull requests:       cortex 1.14.0 (https://github.com/Homebrew/homebrew-core/pull/117195)
cortex was not bumped to the Repology version because it's livecheckable.

After:

Mon 05 Dec 16:16:19 ➜  Library/Homebrew master ✗  brew bump cortex --open-pr
==> cortex
Current formula version:  1.13.1
Latest livecheck version: 1.14.0
Latest Repology version:  present only in Homebrew
Open pull requests:       cortex 1.14.0 (https://github.com/Homebrew/homebrew-core/pull/117195)

Basically the output about "not bumping because livecheckable" should not happen in the case software is unique to Homebrew.

@BrewTestBot
Copy link
Member

Review period will end on 2022-12-06 at 15:22:59 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 5, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 6, 2022
@BrewTestBot
Copy link
Member

Review period ended.

@dawidd6 dawidd6 merged commit a4d2aa8 into Homebrew:master Dec 6, 2022
@dawidd6 dawidd6 deleted the bump-check-is-a-version branch December 6, 2022 20:24
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants