Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-cmd/audit: enable --[no-]signing flag for audits #14219

Merged
merged 2 commits into from Dec 6, 2022
Merged

dev-cmd/audit: enable --[no-]signing flag for audits #14219

merged 2 commits into from Dec 6, 2022

Conversation

bevanjkay
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Enables the --[no-]signing flag for auditing casks.

Should fix the error on - Homebrew/homebrew-cask#137074

@BrewTestBot
Copy link
Member

Review period will end on 2022-12-07 at 00:02:12 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 6, 2022
@bevanjkay bevanjkay changed the title dev-cmd/audit: enable --[no]-signing flag for audits dev-cmd/audit: enable --[no-]signing flag for audits Dec 6, 2022
@bevanjkay @MikeMcQuaid
Update Library/Homebrew/dev-cmd/audit.rb
74092bc 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Dec 6, 2022
@MikeMcQuaid
Copy link
Member

Thanks @bevanjkay!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 6, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

Katt33rd
Katt33rd reviewed Dec 6, 2022
View reviewed changes
Copy link

@Katt33rd Katt33rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcQuaid MikeMcQuaid merged commit f656f81 into Homebrew:master Dec 6, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Katt33rd Katt33rd Katt33rd left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bevanjkay @BrewTestBot @MikeMcQuaid @Katt33rd