Cleanup search module #14260
Merged
Cleanup search module #14260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't need to be isolated anymore because there is a check for the formula and cask args and formula is passed by default on Linux now.
- Move cask logic back into method from extend/os and check whether to display it based on args since formula? is passed by default on Linux now - Use #search_descriptions in `brew desc` instead of duplicating logic - Remove need for extend/os/search
- Instead use class methods. - This is better than use it as a mixin when only a small number of methods are used in each class or module. - It also allows us to conditionally require it in `brew install`. - Removed unused search require in descriptions.rb.
|
Review period will end on 2022-12-20 at 00:00:00 UTC. |
BrewTestBot
added
the
waiting for feedback
apainintheneck
commented
Dec 17, 2022
| @@ -3,15 +3,12 @@ | |||
|
|
|||
| require "formula" | |||
| require "formula_versions" | |||
| require "search" | |||
There was a problem hiding this comment.
This didn't seem to be getting used at all in here.
|
Now I'm wondering if a |
Yeh: if we're using |
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Dec 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?This is a cleanup of the search related logic that is related to #14240.
Essentially, it does a few things.
extend/ossince the change to passing the--formulaeverywhere.cmd/desc.rbandsearch.rbso I changed it so both usesearch.rb.extend/osfor the reason given above andextend/os/searchhas now been removed.search.rbinto class methods and stops extending/including it. This is mostly a style thing. It has the advantages of not polluting the local namespace, allowing us to conditionally include it, and also makes it easier to see which methods are external and internal to a file.Of the above three changes I think the first two are no-brainers while I could be convinced that the third one is unnecessary since it's mostly a style thing.
To test for regressions I tested the following commands along with their
--caskand--formulacounterparts.Results
Results
Results