Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bitdefender diagnostic check #14300

Conversation

apainintheneck
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This check was added in four years ago in #5614. We were seeing problems at the time with users not being able to download packages correctly when running BitDefender (#4579 and #5558).

Those issues were apparently resolved by BitDefender and we got an issue in mid 2020 asking us to remove the check since it was no longer necessary (#7452). Since that point we haven't received anymore issues or complaints related to BitDefender in either the main brew repo or in the discussions (I just searched for bitdefender in both places).

Also, anecdotally, I haven't had any problems using brew and BitDefender at the same time on my local system.

CC: @MikeMcQuaid since you added the check and were involved in previous discussions.

This shows up in `brew doctor` but hasn't been
reported as a problem by users in 3+ years.
@BrewTestBot
Copy link
Member

Review period will end on 2022-12-29 at 19:04:45 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 28, 2022
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. Should re-add the minute anything related crops up again.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 29, 2022
@BrewTestBot
Copy link
Member

Review period ended.

@apainintheneck apainintheneck merged commit d84d4b5 into Homebrew:master Dec 30, 2022
@apainintheneck apainintheneck deleted the remove-bitdefender-diagnostic-check branch January 3, 2023 00:29
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants