Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error message with instructions for the missing cask file #14509

Merged
merged 2 commits into from
Feb 5, 2023
Merged

Add error message with instructions for the missing cask file #14509

merged 2 commits into from
Feb 5, 2023

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Feb 5, 2023 •
edited

Follow up to #14506

We should show a better error message in this case. Now, it shows:

$ brew upgrade --cask emacs
==> Upgrading 1 outdated package:
Error: The cask 'emacs' was not properly installed and cannot be upgraded. To fix this, run:
  brew reinstall --cask --force emacs

I would have liked to actually fix this so no alternate command is needed, but I think that would end up being too much work and too janky so this is the second best option.

@Rylan12 Rylan12 added the critical Critical change which should be shipped as soon as possible. label Feb 5, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Rylan12 Rylan12 added the install from api Relates to API installs label Feb 5, 2023
MikeMcQuaid
MikeMcQuaid approved these changes Feb 5, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine as-is but I think noting it's our fault somehow may help. Thanks again!

Library/Homebrew/cask/cmd/upgrade.rb Outdated Show resolved Hide resolved
@Rylan12 @MikeMcQuaid
Clarify cause of the bug in messaging
dde44ed 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@Rylan12 Rylan12 merged commit cfde9b8 into Homebrew:master Feb 5, 2023
@Rylan12 Rylan12 deleted the missing-caskfile branch February 5, 2023 15:35
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. install from api Relates to API installs outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rylan12 @BrewTestBot @MikeMcQuaid