New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linkage_checker: add libquadmath #14653
Conversation
Review period will end on 2023-02-17 at 03:22:02 UTC. |
Is it commonly installed by default by the system though? We keep our system dependencies minimal to what are provided by default in virtually all distributions (glibc, libstdc++, libgcc_s, etc.). If the system version of library wasn't found, it's not like brew will auto install GCC - it will try to build from source instead, which isn't an optimal experience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's preinstalled (on docker at least, with ubuntu 22). I think it's just part of the standard gcc installation (under /usr/lib/gcc/x86_64-linux-gnu/11/libquadmath.so).
We ask our users to have gcc installed on Linux as part of the build essentials or development tools.
Change looks good to me.
We might suggest it in places but we do not require the full GCC toolchain to be installed anymore. It's not been required for a while, but it was only cleaned up from documentation last year: 1882ae4 At the moment however, we do check |
For some reason I actually misread this PR as libgfortran at first, which definitely isn't always installed as standard but is a part of the full GCC toolchain we provide. libquadmath however we can probably get away with so I'm fine either way. |
|
On Debian/Ubuntu, What is required minimal packages to install on Fedora? I don't think the 64-bit library ( For example, Fedora's |
Disabling auto-merge for now so this is in 4.0.2 not 4.0.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Fedora/centos we ask for the 'Development tools' package.
https://docs.brew.sh/Homebrew-on-Linux#requirements
This brings in gcc
. But we will to ask our users to install gcc-gfortran
for that platform.
Should algol68g
not depend on gcc
instead?
Review period ended. |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?We have noticed in Homebrew/homebrew-core#123264 that
libquadmath.so.0
is also provided by GCC. This is primarily used by Fortran applications (in which caselibquadmath.so.0
is provided by brewed GCC), but on occasion C or C++ programs link to this as well andbrew audit
should allow linkage to the system version of this library.