Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formula_installer: fix resource fetching for source builds under API #14679

Merged
merged 1 commit into from Feb 17, 2023
Merged

formula_installer: fix resource fetching for source builds under API #14679

merged 1 commit into from Feb 17, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Feb 17, 2023

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Feb 17, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

Rylan12
Rylan12 approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@Bo98 Bo98 merged commit 9719695 into Homebrew:master Feb 17, 2023
@Bo98 Bo98 deleted the api-source-fetch branch February 17, 2023 13:14
MikeMcQuaid
MikeMcQuaid approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to merge but, as mentioned in Slack, I'd really like to reconsider this --build-from-source support using the API if we have any more issues in the near future.

@m4ur1c1o m4ur1c1o mentioned this pull request Mar 9, 2023
Closed
3 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@carlocab carlocab carlocab approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

brew upgrade tmux fails to find recent patch
5 participants
@Bo98 @BrewTestBot @MikeMcQuaid @carlocab @Rylan12