Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows/tests: cache update-test's bundler. #14688

Merged
merged 1 commit into from Feb 17, 2023
Merged

workflows/tests: cache update-test's bundler. #14688

merged 1 commit into from Feb 17, 2023

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Feb 17, 2023 •
edited

This is only run on macOS for some reason but no harm in caching on both.

Should speed things up, as mentioned in #14660 (comment)

@MikeMcQuaid
workflows/tests: cache update-test's bundler.
9c96bf1 
This is only run on macOS for some reason but no harm in caching on
both.
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Feb 17, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid mentioned this pull request Feb 17, 2023
Merged
Bo98
Bo98 approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the setup-homebrew changes are merged, we might be able to use v3. But I'll look at that for a separate PR since actions/cache is notorious for failing silently so need to watch the logs.

@MikeMcQuaid MikeMcQuaid merged commit 43a542a into Homebrew:master Feb 17, 2023
@MikeMcQuaid MikeMcQuaid deleted the update_test_bundler branch February 17, 2023 16:17
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MikeMcQuaid @BrewTestBot @Bo98