sorbet: Run brew typecheck --update --suggest-typed on schedule in CI
#14921
Conversation
- No idea if this works, let's experiment. - Suggested in Homebrew#14893 (comment).
|
Review period will end on 2023-03-08 at 23:09:33 UTC. |
BrewTestBot
added
the
waiting for feedback
.github/workflows/sorbet.yml
Outdated
| if ! git diff --stat --exit-code "Library/Homebrew/sorbet" | ||
| then | ||
| git add "Library/Homebrew/sorbet" | ||
| git commit -m "sorbet: Update RBI files." \ | ||
| -m "Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow." | ||
|
|
||
| git add "**/*.rb" |
There was a problem hiding this comment.
Can this be any more specific? I'd hate to accidentally include files we don't want.
There was a problem hiding this comment.
Yeh, perhaps limit to Library/Homebrew and maybe exclude vendor or something?
Another random thought: does this only upgrade and never downgrade sigils?
There was a problem hiding this comment.
The vendor directory is already excluded since Spoom uses Sorbet's config file.
It appears that it only upgrades and never downgrades, yes.
.github/workflows/sorbet.yml
Outdated
| if ! git diff --stat --exit-code "Library/Homebrew/sorbet" | ||
| then | ||
| git add "Library/Homebrew/sorbet" | ||
| git commit -m "sorbet: Update RBI files." \ | ||
| -m "Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow." | ||
|
|
||
| git add "**/*.rb" |
There was a problem hiding this comment.
Yeh, perhaps limit to Library/Homebrew and maybe exclude vendor or something?
Another random thought: does this only upgrade and never downgrade sigils?
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
|
Awesome, thanks @issyl0! |
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?typed: true#14893 (comment).