Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keep_alive sample code in formula cookbook #14939

Merged
merged 2 commits into from Mar 15, 2023

Conversation

shanesmith
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Previous syntax is invalid

@@ -965,7 +965,7 @@ Same as above in hash form:
```ruby
service do
run [opt_bin/"beanstalkd", "test"]
keep_alive { always: true }
keep_alive always: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
keep_alive always: true
keep_alive always: true

everywhere.

@SMillerDev SMillerDev removed their request for review March 14, 2023 09:59
@MikeMcQuaid MikeMcQuaid merged commit 5a0cdaa into Homebrew:master Mar 15, 2023
25 of 26 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants