cmd/{rb,nod}env-sync: add new commands. #14972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
added
the
critical
|
Review period ended. |
BrewTestBot
approved these changes
Mar 14, 2023
MikeMcQuaid
force-pushed
the
rbenv-nodenv-sync
branch
from
3e01fd7
to
ab891b6
Compare
Rylan12
approved these changes
Mar 15, 2023
Bo98
reviewed
Mar 15, 2023
Library/Homebrew/cmd/nodenv-sync.rb
Outdated
Comment on lines
51
to
63
| def gem_like_version(version_path) | ||
| Gem::Version.new(version_path.basename | ||
| .to_s | ||
| .tr("_", ".")) | ||
| end | ||
|
|
||
| def gem_version_segments(version_path) | ||
| basename_without_revision = version_path.basename | ||
| .to_s | ||
| .gsub(/_\d+$/, "") | ||
| Gem::Version.new(basename_without_revision) | ||
| .canonical_segments | ||
| end |
There was a problem hiding this comment.
Any particular reason we're not using our Version?
There was a problem hiding this comment.
@Bo98 Just because it used to live in Not Homebrew. Ported to use Keg and Version from us now, bit nicer from that, thanks for suggestion!
Add these commands to ease use of Homebrew's bottles with `rbenv` and `nodenv`. I've had a lot of people request this over the years and it's worked well for me for a long time. I could see people extending these to support other languages or version managers so perhaps we want a more generic name. Co-authored-by: Rylan Polster <rslpolster@gmail.com>
MikeMcQuaid
force-pushed
the
rbenv-nodenv-sync
branch
from
08a798d
to
b61bf25
Compare
Refactored them a bit instead so not longer needed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add these commands to ease use of Homebrew's bottles with
rbenvandnodenv.I've had a lot of people request this over the years and it's worked well for me for a long time.
I could see people extending these to support other languages or version managers so perhaps we want a more generic name.
Migrated from Homebrew/homebrew-core#125503
Marking as
criticalas already went through some rounds of review over there.