Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/contributions: appropriately pluralize contribution statement #15015

Merged
merged 3 commits into from Mar 19, 2023

Conversation

dtrodrigues
Copy link
Member

@dtrodrigues dtrodrigues commented Mar 19, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Pluralize the contribution statement appropriately

$ brew contributions --user dtrodrigues --from 2023-03-15T01:00:00Z --to 2023-03-15T02:00:00Z --repositories=core
dtrodrigues contributed 1 times between 2023-03-15T01:00:00Z and 2023-03-15T02:00:00Z.

After:

$ brew contributions --user dtrodrigues --from 2023-03-15T01:00:00Z --to 2023-03-15T02:00:00Z --repositories=core
dtrodrigues contributed 1 time between 2023-03-15T01:00:00Z and 2023-03-15T02:00:00Z.

@BrewTestBot
Copy link
Member

Review period will end on 2023-03-21 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 19, 2023
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid
Copy link
Member

Thanks again @dtrodrigues!

auto-merge was automatically disabled March 19, 2023 21:34

Head branch was pushed to by a user without write access

@MikeMcQuaid MikeMcQuaid merged commit 94eafdb into Homebrew:master Mar 19, 2023
21 of 22 checks passed
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 19, 2023
@dtrodrigues dtrodrigues deleted the contributions-plural branch March 20, 2023 02:37
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants