Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toplevel_stanzas. #15028

Merged
merged 1 commit into from Mar 21, 2023
Merged

Fix toplevel_stanzas. #15028

merged 1 commit into from Mar 21, 2023

Conversation

reitermarkus
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Not sure if this fixes anything for the other PRs, but it should at least make tests behave more consistently when using only a single stanza.

@BrewTestBot
Copy link
Member

Review period will end on 2023-03-22 at 13:45:47 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 21, 2023
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand how this fixes it, but as you say it might not.

@reitermarkus
Copy link
Member Author

It will probably fix the tests in your PR since those only contain one stanza. So in

cask do
  on_monterey do
    url 
  end
end

url would previously be considered a top-level stanza, because on_monterey is the only stanza in cask.

@issyl0
Copy link
Member

issyl0 commented Mar 21, 2023

Ohhhh right, I get it, because of the (great!) explanation you gave of the AST parsing in #15013 (comment). Thanks!

@issyl0 issyl0 merged commit a8b1e2c into Homebrew:master Mar 21, 2023
20 of 23 checks passed
@issyl0 issyl0 removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 21, 2023
@reitermarkus reitermarkus deleted the toplevel-stanzas branch March 21, 2023 23:40
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants