Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more typing #15033

Merged
merged 1 commit into from Mar 22, 2023
Merged

Enable more typing #15033

merged 1 commit into from Mar 22, 2023

Conversation

dduugg
Copy link
Sponsor Member

@dduugg dduugg commented Mar 22, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Here are five more files that are fairly straightforward to enable typing in (there are only ~33 non-test files with typing disabled after this change).

@BrewTestBot
Copy link
Member

Review period will end on 2023-03-23 at 04:44:21 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 22, 2023
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks again @dduugg!

@MikeMcQuaid MikeMcQuaid merged commit dea9da6 into Homebrew:master Mar 22, 2023
21 of 23 checks passed
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 22, 2023
@dduugg dduugg deleted the enable-types branch March 22, 2023 19:19
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants