Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocop: Remove the final Naming/MethodParameterName exceptions: pr #15046

Merged
merged 1 commit into from Mar 24, 2023

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Mar 24, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

  • Core RuboCop didn't want this shortening upstreamed, but that's OK!

- Core RuboCop didn't want this shortening upstreamed, but that's OK!
@MikeMcQuaid MikeMcQuaid merged commit fad8ded into Homebrew:master Mar 24, 2023
22 checks passed
@MikeMcQuaid
Copy link
Member

Thanks @issyl0!

@issyl0 issyl0 deleted the rubocop-method-parameter-pr branch March 24, 2023 09:51
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants