Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Allow resource blocks to include on_* blocks or conditionals" #15079

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Revert "Allow resource blocks to include on_* blocks or conditionals" #15079

merged 1 commit into from
Mar 29, 2023

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Mar 28, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This reverts commit b4cd90a.

This should never have been merged but I didn't realise I hadn't backed it out of #15060 before it was approved and I merged it.

We had a multi-person discussion and it was decided against in Homebrew/homebrew-core#126705 (comment).

@issyl0
Revert "Allow resource blocks to include on_* blocks or condition…
9302090 
…als"

This reverts commit b4cd90a.

This should never have been merged, given its extraction into PR 15062
had a reasonably long discussion and was decided against in
Homebrew/homebrew-core#126705 (comment),
but I didn't realise I hadn't backed it out of PR 15060 before it was
approved and I merged it.
@issyl0 issyl0 enabled auto-merge March 29, 2023 08:35
@issyl0 issyl0 added the critical Critical change which should be shipped as soon as possible. label Mar 29, 2023
@issyl0 issyl0 merged commit 85dd9bd into Homebrew:master Mar 29, 2023
25 checks passed
@issyl0 issyl0 deleted the revert-allowing-resource-blocks-to-have-conditionals-or-on-blocks branch March 29, 2023 11:11
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@issyl0 @BrewTestBot