Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix brew install --skip-post-install #15106

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

ywwry66
Copy link
Contributor

@ywwry66 ywwry66 commented Mar 31, 2023

Previous #15042 doesn't pass the flag all the way to FormulaInstaller.new

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Previous Homebrew#15042 doesn't pass the flag all the way to
`FormulaInstaller.new`
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@carlocab carlocab merged commit 13f4ecc into Homebrew:master Mar 31, 2023
24 checks passed
@ywwry66 ywwry66 deleted the skip_post_install branch March 31, 2023 13:25
@github-actions github-actions bot added the outdated PR was locked due to age label May 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants