Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Split prof gems into their own group" #15142

Merged
merged 2 commits into from Apr 4, 2023

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Apr 4, 2023

Reverts #15112
Reverts #15134

This broke the Sorbet workflow (was fixed, reverting here too as this will break it) and the Vendor Gems workflow (still broken https://github.com/Homebrew/brew/actions/runs/4600329850/jobs/8137146086). The latter prevents any gem updates.

CC @Bo98 and @dduugg FYI.

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Apr 4, 2023
@MikeMcQuaid MikeMcQuaid merged commit 7dbe1b4 into master Apr 4, 2023
24 of 25 checks passed
@MikeMcQuaid MikeMcQuaid deleted the revert-15112-prof-group branch April 4, 2023 09:07
@Bo98
Copy link
Member

Bo98 commented Apr 10, 2023

Sorry, I missed this notification - will take a look during the Orka maintenance tomorrow.

@github-actions github-actions bot added the outdated PR was locked due to age label May 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants