cask/utils: Make more noise when encountering undefined methods #15149
Conversation
- https://github.com/Homebrew/homebrew-cask/actions/runs/4608585102/jobs/8144571098 introduced syntax errors for the `mattermost` cask (`autoupdates` instead of `auto_updates`), but CI didn't fail so we didn't notice until it shipped to users and broke `brew update`.
issyl0
force-pushed
the
more-noisy-on-unknown-cask-methods
branch
from
0727175
to
7cfa544
Compare
| @@ -104,7 +104,7 @@ def self.method_missing_message(method, token, section = nil) | |||
| message << "during #{section} " if section | |||
| message << "on Cask #{token}." | |||
|
|
|||
| opoo "#{message}\n#{error_message_with_suggestions}" | |||
| ofail "#{message}\n#{error_message_with_suggestions}" | |||
There was a problem hiding this comment.
Makes sense to me but @Homebrew/cask folks may have an opinion about whether we want to keep opoo/a warning for users rather than maintainers here?
There was a problem hiding this comment.
I'd prefer we throw an error for everyone. No busted syntax allowed ❌
|
Does this now fail for casks that are already installed? We don't want to fail reading installed casks. For example, if we remove |
Agreed but: feels like they shouldn't warn in this situation, either? |
|
No, it should work the same as |
|
@reitermarkus Agreed! |
|
That's fine with me. |
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?mattermostcask (autoupdatesinstead ofauto_updates), but CI didn't fail so we didn't notice until it shipped to users and brokebrew update.