Revert "Revert "Split prof gems into their own group"" #15183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
reviewed
Apr 10, 2023
Library/Homebrew/utils/gems.rb
Outdated
| @@ -12,6 +12,8 @@ module Homebrew | |||
| # After updating this, run `brew vendor-gems --update=--bundler`. | |||
| HOMEBREW_BUNDLER_VERSION = "2.3.26" | |||
|
|
|||
| VALID_GEM_GROUPS = ["sorbet", "prof"].freeze | |||
There was a problem hiding this comment.
Could this be read from the Gemfile instead of being hardcoded?
There was a problem hiding this comment.
Will have a look and see if there's a public API for that.
There was a problem hiding this comment.
We already use some Gem methods so should be doable.
| @@ -45,10 +45,11 @@ def self.typecheck_args | |||
| def self.typecheck | |||
| args = typecheck_args.parse | |||
|
|
|||
| Homebrew.install_bundler_gems!(groups: ["sorbet"]) | |||
| update = args.update? || args.update_all? | |||
| Homebrew.install_bundler_gems!(groups: update ? VALID_GEM_GROUPS : ["sorbet"]) | |||
There was a problem hiding this comment.
Could this get split out into a named variable? A bit hard to parse as-is.
carlocab
approved these changes
Apr 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland this so we can release a new portable Ruby, this time fixing
brew typecheck --updateto install all gems.Obsoletes the fix in #15134 so we shouldn't need to reland that.