Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/update-maintainers: fix undefined method #15192

Merged
merged 1 commit into from Apr 11, 2023

Conversation

ZhongRuoyu
Copy link
Member

@ZhongRuoyu ZhongRuoyu commented Apr 10, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This should fix Error: undefined method `slice!' for #<Hash:0x0000000003c557a8> from https://github.com/Homebrew/brew/actions/runs/4659983623/jobs/8247503227#step:6:74.

@apainintheneck
Copy link
Contributor

apainintheneck commented Apr 11, 2023

Out of curiosity, do we know why this broke in the first place? The update-maintainers.rb file hasn't been touched in a while.

Edit: Maybe it was a transitive require somewhere else before?

@ZhongRuoyu
Copy link
Member Author

ZhongRuoyu commented Apr 11, 2023

Edit: Maybe it was a transitive require somewhere else before?

I think so too. This run from 3e2c713 was the last good run, and this from e5c0fb4 was the first bad run. That should narrow down the search range to b180133 (#14917) and e5c0fb4 (#14892) but I didn't see any suspicious requires getting removed. 🤔

@MikeMcQuaid MikeMcQuaid merged commit 294ea23 into Homebrew:master Apr 11, 2023
24 checks passed
@MikeMcQuaid
Copy link
Member

Thanks @ZhongRuoyu!

@ZhongRuoyu ZhongRuoyu deleted the update-maintainers-slice branch April 11, 2023 09:44
@github-actions github-actions bot added the outdated PR was locked due to age label May 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants