Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-cmd/audit: remove unused warnings key. #15269

Merged
merged 1 commit into from Apr 19, 2023
Merged

dev-cmd/audit: remove unused warnings key. #15269

merged 1 commit into from Apr 19, 2023

Conversation

MikeMcQuaid
Copy link
Member

These are now all errors so the code can be simplified.

@MikeMcQuaid MikeMcQuaid requested a review from issyl0 April 19, 2023 09:04
@MikeMcQuaid MikeMcQuaid mentioned this pull request Apr 19, 2023
Merged
7 tasks
issyl0
issyl0 approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Mike!

@MikeMcQuaid
dev-cmd/audit: remove unused warnings key.
2ca3f73 
These are now all errors so the code can be simplified.
@MikeMcQuaid MikeMcQuaid merged commit 71de574 into Homebrew:master Apr 19, 2023
24 checks passed
@MikeMcQuaid MikeMcQuaid deleted the audit_no_warnings branch April 19, 2023 15:22
@github-actions github-actions bot added the outdated PR was locked due to age label May 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@issyl0 issyl0 issyl0 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MikeMcQuaid @issyl0