Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test. #15460

Merged
merged 1 commit into from
May 19, 2023
Merged

Fix failing test. #15460

merged 1 commit into from
May 19, 2023

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented May 19, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

CI is broken because example.com doesn't return an Accept-Ranges header anymore. We shouldn't actually curl it anyways in tests.

@reitermarkus reitermarkus added the critical Critical change which should be shipped as soon as possible. label May 19, 2023
@reitermarkus reitermarkus requested a review from a team May 19, 2023 12:01
end

# Any value for `accept-ranges` other than none indicates that the server supports partial requests.
# Its absence indicates no support.
supports_partial = headers.key?("accept-ranges") && headers["accept-ranges"] != "none"
supports_partial = headers&.key?("accept-ranges") && headers["accept-ranges"] != "none"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
supports_partial = headers&.key?("accept-ranges") && headers["accept-ranges"] != "none"
supports_partial = headers.fetch("accept-ranges", "none") != "none"

But you'll need to return {} after ErrorDuringExecution above.

@reitermarkus reitermarkus merged commit 08cffe0 into Homebrew:master May 19, 2023
24 checks passed
@reitermarkus reitermarkus deleted the fix-curl-test branch May 19, 2023 12:23
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants