Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shims/mac: handle usage of Homebrew make #15666

Merged
merged 1 commit into from Jul 12, 2023
Merged

shims/mac: handle usage of Homebrew make #15666

merged 1 commit into from Jul 12, 2023

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

We have a handful of formulae that use Homebrew make to build. Doing
this evades our compiler shims. Let's try to avoid this by allowing our
shims to support usage of Homebrew make by calling it as gmake in
the formula.

@carlocab
shims/mac: handle usage of Homebrew make
9ece93e 
We have a handful of formulae that use Homebrew `make` to build. Doing
this evades our compiler shims. Let's try to avoid this by allowing our
shims to support usage of Homebrew `make` by calling it as `gmake` in
the formula.
@carlocab carlocab requested a review from Bo98 July 11, 2023 18:21
Bo98
Bo98 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlocab carlocab merged commit ae7b791 into Homebrew:master Jul 12, 2023
24 checks passed
@carlocab carlocab deleted the make-shim branch July 12, 2023 02:51
carlocab added a commit to carlocab/homebrew-core that referenced this pull request Jul 12, 2023
@carlocab
podman: call make as gmake
5fa9de0 
This ensures that our compiler shims are used correctly. See
Homebrew/brew#15666.
@carlocab carlocab mentioned this pull request Jul 12, 2023
Merged
6 tasks
@carlocab carlocab mentioned this pull request Jul 12, 2023
Merged
6 tasks
carlocab added a commit to carlocab/homebrew-core that referenced this pull request Jul 12, 2023
@carlocab
newsboat: avoid compiler shim evasion
724a5f3 
See Homebrew/brew#15666.
@carlocab carlocab mentioned this pull request Jul 12, 2023
Merged
6 tasks
carlocab added a commit to carlocab/homebrew-core that referenced this pull request Jul 12, 2023
@carlocab
uutils-coreutils: use compiler shims
2cc4eab 
See Homebrew/brew#15666.
@carlocab carlocab mentioned this pull request Jul 12, 2023
Merged
6 tasks
carlocab added a commit to carlocab/homebrew-core that referenced this pull request Jul 12, 2023
@carlocab
blink: ensure compiler shims are configured correctly
19acd60 
See Homebrew/brew#15666.
@MikeMcQuaid
Copy link
Member

Thanks @carlocab!

@github-actions github-actions bot added the outdated PR was locked due to age label Aug 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carlocab @MikeMcQuaid @Bo98