Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/pypi: don't overwrite name/extras/version from basic_metadata if already set #15692

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

dtrodrigues
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

When any of @name, @extras, or @version aren't set, all are attempted to be inferred from the original URL. This change only updates the variables if they weren't already set.

Resolves #15653

@carlocab carlocab requested a review from woodruffw July 18, 2023 05:38
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me!

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me too, will get @woodruffw to give final confirmation!

Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this was roughly the patch I had in mind. Thank you @dtrodrigues!

@MikeMcQuaid MikeMcQuaid merged commit 79e6773 into Homebrew:master Jul 18, 2023
24 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump-formula-pr doesn't update the dependencies of a Python Formula.
4 participants