Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-cmd/bump-*-pr: avoid installing gems when unneeded. #15701

Merged
merged 1 commit into from
Jul 18, 2023
Merged

dev-cmd/bump-*-pr: avoid installing gems when unneeded. #15701

merged 1 commit into from
Jul 18, 2023

Conversation

MikeMcQuaid
Copy link
Member

Fixes #15686

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Jul 18, 2023
@MikeMcQuaid MikeMcQuaid merged commit 1423543 into Homebrew:master Jul 18, 2023
25 checks passed
@MikeMcQuaid MikeMcQuaid deleted the bump_install_bundler branch July 18, 2023 10:08
Bo98
Bo98 reviewed Jul 18, 2023
View reviewed changes
Library/Homebrew/dev-cmd/bump-cask-pr.rb
Homebrew.install_bundler_gems!
# This will be run by `brew audit` or `brew style` later so run it first to
# not start spamming during normal output.
Homebrew.install_bundler_gems! if args.no_audit? && args.no_style?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should be if !args.no_audit? || !args.no_style?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bo98 thanks: #15703

@MikeMcQuaid MikeMcQuaid mentioned this pull request Jul 18, 2023
Merged
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 left review comments

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only call install_bundler_gems if needed
3 participants
@MikeMcQuaid @Bo98 @BrewTestBot