Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Fixes Homebrew/homebrew-cask#152726.
This is an issue that affects only casks that have a
depends_on formula
clause, and only when that formula has uninstalled test dependencies somewhere in its tree. In this situation,brew
when installing the cask will also install the test dependencies, even though they are not needed. Not many casks have adepends_on formula
clause, so I don't expect the issue to be very common; so far I've seen this issue when installing the casksneovide
andgoneovim
.I did a search for the function this commit modifies, and it seems to only be used in
upgrade.rb
andcask/installer.rb
, which would explain why the issue was observed only when installing casks and not formulae. I testedbrew reinstall --cask neovide
with this commit and did not observe the installation of the extraneous dependencies as in Homebrew/homebrew-cask#152726, so this should fix that issue.Although this did not fail the
brew style
check, I'm not entirely sure if this fix matches Homebrew's style, so please let me know if an alternate fix is preferred.