Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/prof: bleed less of the environment from gem installs #15893

Merged
merged 1 commit into from Aug 21, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Aug 21, 2023

This adjusts brew prof to pass setup_path: false to Homebrew.install_bundler_gems! so that all of the BUNDLE_ environment variables don't leak to the subprocess, which can have an impact on how it runs, in particular with external taps using a different set of gems (e.g. Homebrew/formula-analytics).

@MikeMcQuaid MikeMcQuaid merged commit 8dd2073 into Homebrew:master Aug 21, 2023
24 checks passed
@MikeMcQuaid
Copy link
Member

Thanks again @Bo98!

@Bo98 Bo98 deleted the prof-env branch August 21, 2023 13:52
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants