Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependency: consider bounds when comparing macOS deps #15920

Merged
merged 1 commit into from Aug 29, 2023
Merged

dependency: consider bounds when comparing macOS deps #15920

merged 1 commit into from Aug 29, 2023

Conversation

EricFromCanada
Copy link
Member

An improved take on #15907 as per #15919 (comment).

MikeMcQuaid
MikeMcQuaid approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but will let @Bo98 👍🏻 and 🚢.

@MikeMcQuaid MikeMcQuaid requested a review from Bo98 August 29, 2023 11:55
Bo98
Bo98 approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bo98 Bo98 merged commit 9809473 into Homebrew:master Aug 29, 2023
24 checks passed
@ZhongRuoyu ZhongRuoyu mentioned this pull request Aug 29, 2023
Merged
1 task
@EricFromCanada EricFromCanada deleted the macos-deps-caching branch September 11, 2023 16:55
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@Bo98 Bo98 Bo98 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EricFromCanada @MikeMcQuaid @Bo98