Cleanup various TODOs #15937
Merged
Cleanup various TODOs #15937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
reviewed
Sep 2, 2023
issyl0
reviewed
Sep 2, 2023
MikeMcQuaid
force-pushed
the
cleanup_todo
branch
from
56a1a4c
to
c740e89
Compare
These were also easily fixed, already fixed or incorrect and non-controversial. Co-authored-by: Issy Long <issyl0@github.com>
MikeMcQuaid
force-pushed
the
cleanup_todo
branch
from
c740e89
to
f736075
Compare
MikeMcQuaid
added
the
critical
BrewTestBot
approved these changes
Sep 3, 2023
apainintheneck
added a commit
to apainintheneck/homebrew-test-bot
that referenced
this pull request
Sep 17, 2023
This is a follow-up to changes that added os/arch combinations a few months ago. They were made the default temporarily until the references to `brew readall` in the other Homebrew repos were updated as well. - Homebrew/brew#15470 - Homebrew/brew#15937 (comment)
apainintheneck
added a commit
to apainintheneck/homebrew-cask
that referenced
this pull request
Sep 17, 2023
This is a follow-up to changes that added os/arch combinations a few months ago. They were made the default temporarily until the references to `brew readall` in the other Homebrew repos were updated as well. - Homebrew/brew#15470 - Homebrew/brew#15937 (comment)
apainintheneck
added a commit
to apainintheneck/brew
that referenced
this pull request
Sep 17, 2023
Removes temporary default to readall for every os/arch combination after updating brew-test-bot and brew/cask to pass the appropriate arguments in on CI. - Homebrew#15470 - Homebrew#15937 (comment)
apainintheneck
added a commit
to apainintheneck/brew
that referenced
this pull request
Sep 17, 2023
Removes temporary default to readall for every os/arch combination after updating brew-test-bot and brew/cask to pass the appropriate arguments in on CI. - Homebrew#15470 - Homebrew#15937 (comment) Also, add more constants for os/arch combinations. This allows us to make validating all os/arch combinations the default in `Readall.valid_tap?` which is needed to keep the same behavior in `brew tap` that we had before. I also updated a few other spots around the codebase to use those new constants. One more thing was updating the integration test. In local testing, this didn't change the runtime so it seemed like a no-brainer.
10 tasks
apainintheneck
added a commit
to apainintheneck/brew
that referenced
this pull request
Sep 17, 2023
Removes temporary default to readall for every os/arch combination after updating brew-test-bot and brew/cask to pass the appropriate arguments in on CI. - Homebrew#15470 - Homebrew#15937 (comment) Also, add more constants for os/arch combinations. This allows us to make validating all os/arch combinations the default in `Readall.valid_tap?` which is needed to keep the same behavior in `brew tap` that we had before. I also updated a few other spots around the codebase to use those new constants. One more thing was updating the integration test. In local testing, this didn't change the runtime so it seemed like a no-brainer.
apainintheneck
added a commit
to apainintheneck/brew
that referenced
this pull request
Sep 19, 2023
Removes temporary default to readall for every os/arch combination after updating brew-test-bot and brew/cask to pass the appropriate arguments in on CI. - Homebrew#15470 - Homebrew#15937 (comment) Also, add more constants for os/arch combinations. This allows us to make validating all os/arch combinations the default in `Readall.valid_tap?` which is needed to keep the same behavior in `brew tap` that we had before. I also updated a few other spots around the codebase to use those new constants. One more thing was updating the integration test. In local testing, this didn't change the runtime so it seemed like a no-brainer.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were also easily fixed, already fixed or incorrect and non-controversial.