os/mac/hardware: remove TODO. #15938
Conversation
|
Rosetta probably got a spike in usage really with the Gaming Porting Toolkit that came out. If I'm reading analytics correctly, Rosetta looks like it might cover about 800,000, or about 10% of arm64 installs, in the last month which is relatively high. This change feels problematic given some formulae (e.g. pkg-config, compilers) need per-OS bottles and we will not be offering them anymore with this change, and we'll also be stuck if Rosetta is still used 2 years from now when we drop Ventura which seems likely with the way Apple have moved recently. |
|
I tend to agree with @Bo98: this will break some formulas, while we know there is still significant Rosetta 2 usage. On the other hand, the AVX optimisation is, well, probably negligible for most formulas anyway. And I hope people who have CPU-bound apps or heavily computational needs compile from source rather than use a distro, anyway. |
As discussed in #15938, this TODO can pretty much never be done so doesn't make sense to leave as-is.
MikeMcQuaid
force-pushed
the
sonoma_rosetta_2_bottles
branch
from
1322596
to
f307880
Compare
MikeMcQuaid
changed the title
|
@Bo98 @fxcoudert good points, I agree. As a result, I've rescoped this PR to remove the TODO instead as we can never really implement it. |
MikeMcQuaid
added
the
critical
As discussed in Homebrew#15938, this TODO can pretty much never be done so doesn't make sense to leave as-is.
As discussed in comments, this TODO can pretty much never be done so doesn't make sense to leave as-is.