Move gem group setting to separate, cacheable file #15952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
reviewed
Sep 4, 2023
apainintheneck
approved these changes
Sep 8, 2023
Bo98
force-pushed
the
gemgroup-file
branch
2 times, most recently
from
2d60207
to
adc3157
Compare
MikeMcQuaid
reviewed
Sep 13, 2023
MikeMcQuaid
approved these changes
Sep 13, 2023
|
Thanks again @Bo98! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we stored installed gem groups in the Homebrew settings file (gitconfig). This made sense, but this PR changes that to use a separate file instead.
The benefit of doing so is so that the file can be cached in GitHub Actions, so the same cache can be used across multiple CI workflows even if the groups used in each are different. Otherwise, the previous behaviour would be to just uninstall all the groups not requested in that workflow.