Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install gems automatically on newer Ruby #15955

Merged
merged 2 commits into from Sep 29, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Sep 4, 2023

Untested but should hopefully work.

Target is to make this as painless as possible (e.g. a few seconds, only a basic Ruby is needed with no strings attached). Otherwise I'd rather just do symlink magic instead or just go ahead vendor given we're going to do so within the next couple months anyway.

Draft because untested and also requires all the other PRs.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach makes sense to me, nice work!

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Sep 27, 2023
@Bo98 Bo98 removed the stale No recent activity label Sep 27, 2023
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks!

@Bo98 Bo98 force-pushed the newer-ruby-bootstrap branch 2 times, most recently from 5311f1c to e88a768 Compare September 29, 2023 00:20
@Bo98 Bo98 marked this pull request as ready for review September 29, 2023 00:38
@Bo98 Bo98 merged commit f2c8b2e into Homebrew:master Sep 29, 2023
25 checks passed
@Bo98 Bo98 deleted the newer-ruby-bootstrap branch September 29, 2023 00:52
@MikeMcQuaid
Copy link
Member

Thanks @Bo98!

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants