Formula, BuildError: Update type signatures

[samford]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

We're seeing type errors when building formulae that use something like xcodebuild ..., "-arch", Hardware::CPU.arch, since CPU.arch is a symbol. We've been addressing these issues by calling #to_s on the value but there was some talk about simply expanding the type signatures to accommodate anything that will be cast to a String.

There's maybe still an argument to be made for doing string conversion in formulae but expanding the type signatures will resolve a number of existing type errors if we simply want to rely on implicit type casting.

Past that, this also updates the type signature for BuildError to align with the #system signature changes, as we receive a new type error otherwise.

[samford]

I'm looking into the new brew typecheck failures now that I have brew typecheck working on Sonoma (we currently have to set HOMEBREW_FORCE_VENDOR_RUBY=1).

Edit: I updated the type signature for BuildError to align with the change to #system and now brew typecheck passes.

[SMillerDev]

Symbol looks like a good option

[Bo98]

Yeah to_str kinda sucks when you deal with explicit typing.

I'm guessing Version might appear in a few places too.

[MikeMcQuaid]

Thanks @samford, looks good!