Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/gems: don't allow Sorbet to install on Sonoma's system Ruby #16003

Merged
merged 1 commit into from Sep 14, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Sep 13, 2023

As it is not supported and will error otherwise.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bo98, makes sense!

@MikeMcQuaid MikeMcQuaid merged commit 1a481be into Homebrew:master Sep 14, 2023
26 checks passed
@Bo98 Bo98 deleted the sorbet-sonoma branch September 14, 2023 14:19
@buildpulse
Copy link

buildpulse bot commented Sep 14, 2023

Known disruptive tests have failed for this pull request.

Commit SHA: 1a481be
Build URL: https://github.com/Homebrew/brew/actions/runs/6186785402/attempts/1

Suite Name Test Name Details
rspec SystemCommand with both STDOUT and STDERR output from upstream with default options its result stderr is expected to eq "2\n4\n6\n"

@buildpulse
Copy link

buildpulse bot commented Sep 14, 2023

Known disruptive tests have failed for this pull request.

Commit SHA: 1a481be
Build URL: https://github.com/Homebrew/brew/actions/runs/6186785402/attempts/1

Suite Name Test Name Details
rspec SystemCommand with both STDOUT and STDERR output from upstream with print_stdout echoes both STDOUT and STDERR

@Bo98
Copy link
Member Author

Bo98 commented Sep 14, 2023

Known disruptive tests

Yes it's known for months/years, but super low priority as rspec-retry fixes it.

Not sure why BuildPulse has decided to pick on this pull request randomly, even when it admits it's already "known".

@MikeMcQuaid
Copy link
Member

Known disruptive tests

Yes it's known for months/years, but super low priority as rspec-retry fixes it.

Not sure why BuildPulse has decided to pick on this pull request randomly, even when it admits it's already "known".

I think this is just a new feature (that we probably want to disable).

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants