Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HOMEBREW_SUDO_THROUGH_SUDO_USER #16061

Merged
merged 1 commit into from Oct 1, 2023

Conversation

MikeMcQuaid
Copy link
Member

This environment variable allows telling Homebrew to use the SUDO_USER variable to sudo through that user when Homebrew (Cask) attempts to run sudo.

While we're here, clarify in some messaging that we're running sudo and that that's the password we're asking for; the specific password is configuration dependent and not the specific password for the user.

Similarly, remove the Package installers may write to any location output; it's kinda spammy and doesn't feel like the right place.

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Killer work!

This environment variable allows telling Homebrew to use the `SUDO_USER`
variable to `sudo` through that user when Homebrew (Cask) attempts to
run `sudo`.

While we're here, clarify in some messaging that we're running `sudo`
and that that's the password we're asking for; the specific password is
configuration dependent and not the specific password for the user.

Similarly, remove the `Package installers may write to any location`
output; it's kinda spammy and doesn't feel like the right place.
@MikeMcQuaid MikeMcQuaid merged commit c325404 into Homebrew:master Oct 1, 2023
28 checks passed
@MikeMcQuaid MikeMcQuaid deleted the sudo_through_sudo_user branch October 1, 2023 15:04
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants