Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocops/text: Declare "revision 0" in formulae as unnecessary #16086

Merged
merged 1 commit into from Oct 5, 2023

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Oct 4, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

  • This came up in a user contribution recently so here's a RuboCop for it.
  • I'm getting some weird test failures on Sonoma for some reason so I'll rely on CI for running all of brew tests rather than just the one I wrote.

- This came up in a user contribution recently so here's a RuboCop for it.
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @issyl0!

@MikeMcQuaid MikeMcQuaid merged commit 1085afc into Homebrew:master Oct 5, 2023
27 checks passed
@issyl0 issyl0 deleted the revision-0-not-allowed-in-text branch October 5, 2023 08:02
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants