Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/fetch: restore --HEAD functionality #16095

Merged
merged 1 commit into from Oct 7, 2023

Conversation

EricFromCanada
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

brew fetch was always downloading the stable spec. This fixes that.

@reitermarkus
Copy link
Member

Are there any formulae that have a different head depending on OS/arch? If not, maybe --HEAD should conflict with --os and --arch.

@apainintheneck
Copy link
Contributor

Are there any formulae that have a different head depending on OS/arch? If not, maybe --HEAD should conflict with --os and --arch.

It doesn't look like there are any formulas in core that have multiple head definitions.

$ git grep -El ' head "| head do' | awk '
{ files[$0]++ }
END {
  total = 0
  for(file in files) {
    if(files[file] > 1) total++ 
  }
  print total
}'
0

@EricFromCanada EricFromCanada changed the title cmd/fetch: restore --HEAD functionality cmd/fetch: restore --HEAD functionality Oct 7, 2023
@EricFromCanada EricFromCanada merged commit eef9f84 into Homebrew:master Oct 7, 2023
27 checks passed
@EricFromCanada EricFromCanada deleted the fix-fetch-head branch October 7, 2023 23:54
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants